Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ContextError to an injective type family from a data family #3961

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jan 2, 2024

Description

This change is necessary because we can not use the initial approach of downgrading type families to previous eras. If we don't switch to type family from data family we can not use type families in the errors (eg. TxCert)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehins lehins force-pushed the lehins/context-error-type-family branch from 9c33f8f to 077dbea Compare January 3, 2024 14:26
@lehins lehins enabled auto-merge January 3, 2024 14:26
@lehins lehins merged commit a05204f into master Jan 3, 2024
10 of 27 checks passed
@neilmayhew neilmayhew deleted the lehins/context-error-type-family branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants