-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add estimateMinFeeTx
#3962
Merged
Merged
Add estimateMinFeeTx
#3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
1c048d6
to
1daf15f
Compare
a4d2117
to
51d5b6f
Compare
51d5b6f
to
04bfce9
Compare
Soupstraw
reviewed
Jan 3, 2024
Soupstraw
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
teodanciu
reviewed
Jan 3, 2024
We should also use this in the fixup function of |
teodanciu
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
04bfce9
to
209ec37
Compare
* Add `ByronKeyPair` * Add `Arbitrary` instances for Byron types: `Address`, `Attributes` and `AddrAttributes`
* Add a property test for `estimateMinFeeTx`
209ec37
to
22ae71a
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current version of the function
evaluateTransactionFee
does not handle Byron witnesses and it is not recursive, so it cannot account for the fact that occasionally the change to the fee will affects the size of the transaction and thus the minimum fee. NewestomateMinFeeTx
improves this logicBesides adding this new functionality to ledger API there are a few minor additions:
forceDRepPulsingState
, which can be used to memoize the result of a premature completion of DRep pulserArbitrary
instances for bootstrap addresses andByronKeyPair
type that can be used to test functionality related to Byron addresses and witnessesSignedDSIGN
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)