Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract getWitsVKeyNeeded #3963

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Abstract getWitsVKeyNeeded #3963

merged 3 commits into from
Jan 4, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jan 3, 2024

Description

Turns out GenDelegs is totally unnecessary in the UtxoEnv. This PR removes it.

Also it adds an era agnostic getWitsVKeyNeeded that we can now use in UTXOW rules for all eras.

This is a nice organization and simplification, but the real reason for this change is that we need to provide a proper min fee computation for CLI, which will be implemented in a subsequent PR

Fixes #3485

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins changed the title Lehins/get wits v key needed Abstract getWitsVKeyNeeded Jan 3, 2024
@lehins lehins marked this pull request as draft January 3, 2024 11:15
@lehins lehins marked this pull request as ready for review January 3, 2024 11:27
@lehins lehins force-pushed the lehins/getWitsVKeyNeeded branch 2 times, most recently from c40a763 to fcc862d Compare January 3, 2024 22:01
@lehins lehins enabled auto-merge January 3, 2024 22:01
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Love how the second commit cleans up so much noise, awesome.

@lehins lehins force-pushed the lehins/getWitsVKeyNeeded branch from fcc862d to 43df20b Compare January 4, 2024 07:36
@lehins lehins merged commit faa40b8 into master Jan 4, 2024
10 of 11 checks passed
@neilmayhew neilmayhew deleted the lehins/getWitsVKeyNeeded branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need for ConwayUtxoEnv
2 participants