Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore thunks in utxosDeposited #3964

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Ignore thunks in utxosDeposited #3964

merged 1 commit into from
Jan 4, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jan 3, 2024

Description

This fixes the "thunks present" failures in the nightly tests. We allow thunks in the utxosDeposited field because we only use that field in tests.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw changed the title Ignore thunks in utxosDeposited Ignore thunks in utxosDeposited Jan 3, 2024
@Soupstraw Soupstraw requested review from lehins and teodanciu January 3, 2024 11:21
@Soupstraw Soupstraw force-pushed the jj/utxos-thunks branch 4 times, most recently from 9e74970 to 0a99dc7 Compare January 3, 2024 13:22
@Soupstraw Soupstraw enabled auto-merge (rebase) January 3, 2024 14:43
@Soupstraw Soupstraw requested a review from aniketd January 3, 2024 14:43
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome that it fixes the NoThunks test, I tried without success in the past, probably I missed some bangs 😆
Looks good to me

@Soupstraw Soupstraw merged commit 9b72155 into master Jan 4, 2024
10 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants