Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy hash protection to TreasuryWithdrawals and ParameterChange #3975

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jan 5, 2024

Description

Adds hash protection to TreasuryWithdrawals and ParameterChange. The hashes are checked in the GOV rule, and if a policy script is present, then we require a witness for it in the UTXOW rule.

The tests rely on #3960

resolves #3957

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/proposal-scripts branch 2 times, most recently from d54eb45 to c751b49 Compare January 5, 2024 12:57
@Soupstraw Soupstraw changed the title Add policy hash protection to TreasuryWithdrawals and NewCommittee Add policy hash protection to TreasuryWithdrawals and ParameterChange Jan 5, 2024
@Soupstraw Soupstraw force-pushed the jj/proposal-scripts branch from c751b49 to 440ad2d Compare January 5, 2024 13:53
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 🙂

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/proposal-scripts branch 3 times, most recently from c55031d to 89e89ca Compare January 8, 2024 12:05
@Soupstraw Soupstraw marked this pull request as ready for review January 8, 2024 12:05
@Soupstraw Soupstraw marked this pull request as draft January 8, 2024 12:05
@Soupstraw Soupstraw force-pushed the jj/proposal-scripts branch 2 times, most recently from d793a02 to 061d52a Compare January 8, 2024 13:09
@Soupstraw Soupstraw marked this pull request as ready for review January 8, 2024 14:40
@Soupstraw Soupstraw force-pushed the jj/proposal-scripts branch from 061d52a to 5f5ef5f Compare January 8, 2024 15:04
@Soupstraw Soupstraw requested review from aniketd and teodanciu January 9, 2024 10:38
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what we needed. Thanks!

@teodanciu
Copy link
Contributor

Maybe conway CHANGELOG mentioning the changes in ParameterChange, TreasuryWithdrawals and the new InvalidPolicyHash constructor of ConwayGovPredFailure ?

@Soupstraw Soupstraw force-pushed the jj/proposal-scripts branch 4 times, most recently from 76d583c to b3488fd Compare January 9, 2024 12:00
@Soupstraw Soupstraw enabled auto-merge (rebase) January 9, 2024 12:05
@Soupstraw Soupstraw force-pushed the jj/proposal-scripts branch 2 times, most recently from b827a01 to a351761 Compare January 10, 2024 10:23
@Soupstraw Soupstraw force-pushed the jj/proposal-scripts branch from a351761 to ecbf0f5 Compare January 10, 2024 11:05
@Soupstraw Soupstraw merged commit 4cbd804 into master Jan 10, 2024
10 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of ScriptHash to ParameterChange and TreasuryWithdrawals
3 participants