Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposals pruning rewrite #3978

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Proposals pruning rewrite #3978

merged 1 commit into from
Jan 23, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jan 10, 2024 •
edited
Loading

Description

Closes #3979

Checklist

  • Reexport ConwayEraTxBody from Conway.Core without import cycles
  • Update CHANGELOG
  • Bump versions
  • Write documentation

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch 2 times, most recently from ab78084 to 06b7121 Compare January 10, 2024 10:21
@aniketd aniketd mentioned this pull request Jan 10, 2024
Closed
20 tasks
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch from 06b7121 to 45c2ffc Compare January 10, 2024 12:10
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch from 45c2ffc to 7a6271f Compare January 10, 2024 13:21
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch 2 times, most recently from 8a86ec3 to 5d9041f Compare January 10, 2024 14:44
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch 2 times, most recently from c855294 to 649c58f Compare January 11, 2024 16:32
@aniketd aniketd requested a review from teodanciu January 11, 2024 16:50
lehins
lehins reviewed Jan 12, 2024
View reviewed changes
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Procedures.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Ratify.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Arbitrary.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Arbitrary.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Arbitrary.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Arbitrary.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Arbitrary.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Arbitrary.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
lehins
lehins reviewed Jan 12, 2024
View reviewed changes
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
lehins
lehins reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I'll do a second pass next week once you get a chance to address all the current feedback

eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch 3 times, most recently from 8556721 to 04da19f Compare January 17, 2024 13:00
@aniketd aniketd requested review from Soupstraw and lehins January 17, 2024 13:06
lehins
lehins reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once these comments are addressed, I think we can merge the PR.
This is an awesome piece of work. I love it!

libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Env.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/TreeDiff.hs Outdated Show resolved Hide resolved
eras/conway/impl/cardano-ledger-conway.cabal Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/UTxO.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/GovActionReorderSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/GovActionReorderSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Arbitrary.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch from 04da19f to cb08a48 Compare January 18, 2024 10:41
lehins
lehins approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
👍

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Epoch.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch 3 times, most recently from 2f5e489 to 2b4e0de Compare January 19, 2024 12:53
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch 2 times, most recently from ff82851 to c81eb37 Compare January 21, 2024 07:10
@disassembler disassembler mentioned this pull request Jan 22, 2024
Closed
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch from c81eb37 to 9758b33 Compare January 23, 2024 13:49
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch from 9758b33 to 5bc3ec7 Compare January 23, 2024 13:51
@aniketd aniketd enabled auto-merge (squash) January 23, 2024 15:02
@aniketd aniketd merged commit 829386e into master Jan 23, 2024
10 of 28 checks passed
@lehins lehins mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@TimSheard TimSheard Awaiting requested review from TimSheard

@teodanciu teodanciu Awaiting requested review from teodanciu

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix pruning of unreachable and expired proposals
4 participants
@aniketd @teodanciu @lehins @Soupstraw