Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test proposals rewrite #3981

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Test proposals rewrite #3981

merged 1 commit into from
Feb 5, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jan 10, 2024 •
edited

Description

Closes #3894

Pending

  • Get rid of the pattern synonyms to make sure Conway constraint is done away with and all tests are sufficiently polymorphic over era
  • Reduces duplication by comparing entire tree structures rather than individual proposals
  • Address any other review comments

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd mentioned this pull request Jan 10, 2024
Closed
20 tasks
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch from 98007c3 to 7fa0477 Compare January 10, 2024 11:10
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch 2 times, most recently from 45c2ffc to 7a6271f Compare January 10, 2024 13:21
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch 2 times, most recently from d183298 to 121d7d3 Compare January 10, 2024 13:53
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch from 7a6271f to 8a86ec3 Compare January 10, 2024 14:07
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch from 121d7d3 to e39d1cd Compare January 10, 2024 14:18
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch from 8a86ec3 to 5d9041f Compare January 10, 2024 14:44
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch 2 times, most recently from 9fcb282 to 2552238 Compare January 10, 2024 16:17
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch 2 times, most recently from c855294 to 649c58f Compare January 11, 2024 16:32
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch 2 times, most recently from d9334e1 to e38167c Compare January 11, 2024 18:32
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch 2 times, most recently from be3f7f4 to a0a824c Compare January 12, 2024 12:42
@aniketd aniketd force-pushed the aniketd/proposals-pruning-rewrite branch 3 times, most recently from 8556721 to 04da19f Compare January 17, 2024 13:00
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch from a0a824c to 13f0315 Compare January 17, 2024 14:48
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch from 762b1aa to 7d4b7ed Compare January 24, 2024 18:30
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch 2 times, most recently from 5f3a6e1 to b550eaf Compare January 29, 2024 19:00
@aniketd aniketd changed the base branch from aniketd/proposals-pruning-rewrite to master January 29, 2024 19:01
@aniketd aniketd requested a review from lehins January 29, 2024 19:02
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch 4 times, most recently from 5edf143 to 11c8311 Compare January 30, 2024 10:40
lehins
lehins reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only got a chance to look at parts of the PR.
I'll do a follow up review tomorrow

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Proposals.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Proposals.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch 2 times, most recently from bd14ea1 to d03fc34 Compare February 1, 2024 16:32
lehins
lehins approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better than before. Nice.

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch 5 times, most recently from 1f02514 to c11b5f8 Compare February 5, 2024 19:16
@aniketd aniketd force-pushed the aniketd/proposals-pruning-tests branch from c11b5f8 to 3581f3f Compare February 5, 2024 19:20
@aniketd aniketd enabled auto-merge (squash) February 5, 2024 19:21
@aniketd aniketd merged commit e73acc6 into master Feb 5, 2024
11 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@teodanciu teodanciu Awaiting requested review from teodanciu

@TimSheard TimSheard Awaiting requested review from TimSheard

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test unreachable proposals clean up functionality
3 participants
@aniketd @lehins @Soupstraw