Include reference scripts size in min fee calculation #3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
changed the title
teodanciu
force-pushed
the
td/ref-scripts-size-in-fee-calculation
branch
7 times, most recently
from
5a7b75a to
c185b33
Compare
teodanciu
force-pushed
the
td/ref-scripts-size-in-fee-calculation
branch
5 times, most recently
from
9920dde to
59b8424
Compare
teodanciu
changed the title
9 tasks
teodanciu
force-pushed
the
td/ref-scripts-size-in-fee-calculation
branch
from
59b8424 to
87a08a6
Compare
lehins
approved these changes
Jan 30, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
teodanciu
force-pushed
the
td/ref-scripts-size-in-fee-calculation
branch
4 times, most recently
from
5d4caee to
757ef78
Compare
lehins
reviewed
Jan 31, 2024
teodanciu
force-pushed
the
td/ref-scripts-size-in-fee-calculation
branch
2 times, most recently
from
d803c76 to
f83e998
Compare
teodanciu
force-pushed
the
td/ref-scripts-size-in-fee-calculation
branch
4 times, most recently
from
b5ecf84 to
1300da5
Compare
and `estimateMinFeeTx`, and use it in the calculation of Conway `getMinFeeTx`
and use `estimateMinFeeTx` in tests where necessary.
teodanciu
force-pushed
the
td/ref-scripts-size-in-fee-calculation
branch
from
1300da5 to
dff1911
Compare
This will add the cost for the reference scripts to the computation, starting with Conway.
in order to make tests less fragile. For this, instead of storing only `rootTxId` in `ImpTestState`, we need to store the whole TxIn as `rootTxIn`.
and use it to avoid duplication
teodanciu
force-pushed
the
td/ref-scripts-size-in-fee-calculation
branch
from
dff1911 to
0ffe957
Compare
lehins
added a commit
that referenced
this pull request
Feb 2, 2024
lehins
added a commit
that referenced
this pull request
Feb 2, 2024
lehins
added a commit
that referenced
this pull request
Feb 2, 2024
lehins
added a commit
that referenced
this pull request
Feb 2, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3952
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)