Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libs/cardano-ledger-pretty #3986

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Remove libs/cardano-ledger-pretty #3986

merged 3 commits into from
Jan 16, 2024

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Jan 11, 2024

removed libs/cardano-ledger-pretty
Follow on to PR #3973
This library is no longer supported. Instead a slightly improved version is made part of llibs/cardano-ledger-test

A tiny fix that disallows Ptrs in the stake credential of Conway Addresses.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@TimSheard TimSheard requested a review from lehins January 12, 2024 02:46
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When removing or adding a package or a section in a package we need to run ./scripts/gen-hie.sh, which will make the necessary adjustments.

CHANGELOG.md Outdated Show resolved Hide resolved
@TimSheard TimSheard force-pushed the ts-remove-pretty-library branch from 3ed8a32 to 252afb8 Compare January 12, 2024 18:26
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
@lehins lehins merged commit 94e5534 into master Jan 16, 2024
10 of 12 checks passed
@neilmayhew neilmayhew deleted the ts-remove-pretty-library branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants