Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DRep delegation injections to Conway #3997

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jan 18, 2024

Description

resolves #3995

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/drep-deleg-injection branch 2 times, most recently from 5c47b10 to 15b92a2 Compare January 18, 2024 13:39
@Soupstraw Soupstraw marked this pull request as ready for review January 18, 2024 14:13
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately implementation for injection still has the same problem of requiring to load the whole input into memory, because it has to pass over the source ListMap twice.

I made a suggestion that should help you fix that.

eras/conway/impl/src/Cardano/Ledger/Conway/Transition.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/TxCert.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/drep-deleg-injection branch 4 times, most recently from fbfd8e0 to 3114bc3 Compare January 19, 2024 13:20
@Soupstraw Soupstraw requested a review from lehins January 19, 2024 13:41
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more important issue and I think it is good to go.

eras/conway/impl/src/Cardano/Ledger/Conway/Transition.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Transition.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Transition.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Transition.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-api/CHANGELOG.md Outdated Show resolved Hide resolved
eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/drep-deleg-injection branch 3 times, most recently from 4894926 to aea2b64 Compare January 22, 2024 11:11
@Soupstraw Soupstraw requested a review from lehins January 22, 2024 11:12
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@lehins lehins enabled auto-merge January 22, 2024 12:42
@lehins lehins merged commit 33c0a26 into master Jan 22, 2024
11 of 22 checks passed
@Soupstraw Soupstraw deleted the jj/drep-deleg-injection branch January 23, 2024 12:50
@lehins lehins changed the title Added SPO delegation injections to Conway Added DRep delegation injections to Conway Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRep delegation injection
2 participants