Add PParamUpdates to the plutus context, by transforming them to Plutus Data #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
ts-pparamUpdate-via-Data
branch
from
60d5784 to
749fa0a
Compare
|
Still a work in progress as it doesn't do anything yet with the plutus context |
lehins
requested changes
Jan 19, 2024
There was a problem hiding this comment.
There are some issues in the PR, but the overall direction is great!
The only thing that is missing now is the actual translation to PlutusV3 context and roundtrip tests that should have the reusable functionality placed in cardano-ledger-core:testlib:Test.Cardano.Ledger.Plutus.ToPlutusData
and the actual Conway tests should go into cardano-ledger-conway:tests:Test.Cardano.Ledger.Conway.Plutus.ToPlutusData
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-pparamUpdate-via-Data
branch
5 times, most recently
from
d99889f to
1ea5e01
Compare
lehins
reviewed
Jan 22, 2024
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Plutus/ToPlutusData.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-pparamUpdate-via-Data
branch
from
d144ec8 to
7a4041a
Compare
lehins
changed the title
lehins
force-pushed
the
ts-pparamUpdate-via-Data
branch
3 times, most recently
from
5ad5f34 to
356ae86
Compare
lehins
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
@TimSheard There was a few things still needed to be rearranged in this PR, but because we will try to make a release today and this functionality is needed for the next release I took upon myself to finish this up. Check out the last few commits to see what I've done.
lehins
force-pushed
the
ts-pparamUpdate-via-Data
branch
from
356ae86 to
0296139
Compare
* Add `Cardano.Ledger.Core.Plutus.ToPlutusData` * Add ToPlutusData class * Add ToPlutusData instances in `Cardano.Ledger.Conway.PParams` * Use table driven approach to make instance for PParamsUpdate * Property tests added * Add module `Cardano.Ledger.Conway.Plutus.Context` * Add class `ToPlutusData (PParamsUpdate era) => ConwayEraPlutusTxInfo (l :: Language) era` * Complete module `Cardano.Ledger.Conway.TxInfo` using `ConwayEraPlutusTxInfo` instance
This change is needed for consistency with how the rest of the translation works and to avoid constructing unnecessary `Proxy`, since `Plutus a` is already used as a proxy.
This is necessary to remove such instance for PlutusV1, PlutusV2 and the future languages past PlutusV3. Make `EraPlutusTxInfo` usperclass of `ConwayEraPlutusTxInfo` for consistent hierarchy of classes
lehins
force-pushed
the
ts-pparamUpdate-via-Data
branch
from
0296139 to
6901667
Compare
Soupstraw
pushed a commit
that referenced
this pull request
Jan 25, 2024
Add PParamUpdates to the plutus context, by transforming them to Plutus Data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new class ToPlutusData
Uses table driven approach to make instance for PParamsUpdate
resolves #3994
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)