Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that enacted gov action is removed #4004

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Verify that enacted gov action is removed #4004

merged 2 commits into from
Jan 30, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jan 24, 2024 •
edited
Loading

Description

Changes to the TreasuryWithdrawal tests might seem to be redundant, but they were necessary for reproducing the bug in #4000 in cardano-ledger-conway-1.11

Improvements that are actually useful in this PR is the ability to submit multiple proposals in a single transaction.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins mentioned this pull request Jan 24, 2024
Closed
@lehins lehins marked this pull request as ready for review January 24, 2024 13:32
@lehins lehins changed the title Ensure enacted gov action is removed Verify that enacted gov action is removed Jan 24, 2024
@lehins lehins force-pushed the lehins/ensure-enacted-gov-action-is-removed branch 2 times, most recently from 61e4ea5 to 4a099a3 Compare January 24, 2024 19:12
@lehins lehins requested a review from Soupstraw January 24, 2024 19:13
@lehins lehins force-pushed the lehins/ensure-enacted-gov-action-is-removed branch from 4a099a3 to 14b575a Compare January 30, 2024 08:15
@lehins lehins enabled auto-merge January 30, 2024 08:23
lehins added 2 commits January 30, 2024 09:47
@lehins
Add submitProposals and trySubmitProposal
4b86ec2
@lehins
Add getGovPolicy, submitGovActions and trySubmitGovActions
14b575a 
Improve the TreasuryWithdrawal test

* Besides adding extra checks add an extra unused proposal to treasury
  withdrawal proposals reproduced the bug reported in #4000
@lehins lehins merged commit f459177 into master Jan 30, 2024
10 of 28 checks passed
@neilmayhew neilmayhew deleted the lehins/ensure-enacted-gov-action-is-removed branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soupstraw Soupstraw Soupstraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @Soupstraw