-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Arbitrary instance and invariant checking for Proposals
#4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f7c89d
to
e3861b7
Compare
e3861b7
to
a432bea
Compare
aniketd
reviewed
Jan 29, 2024
aniketd
reviewed
Jan 29, 2024
aniketd
reviewed
Jan 29, 2024
aniketd
reviewed
Jan 29, 2024
aniketd
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super awesome! 💯 🙌
c8899d5
to
8b7cb1b
Compare
Reference for order paramter names should be derived from Plutus, rather than listed in the file in the ledger repo. Starting with Conway cost model parameters decoding is lenient, in that it accepts even unknown parameters, so there is no point in listing all of the ones that are known.
* Fix `Arbitrary` instance for `Proposals`: * Allow empty to be generated * Generate `InfoAction` and `TreasuryWithdrawal` * Remove `proposalsAreConsistent` in favor of `toPForest`. Besides checking the invariant it also constructs a forest of `Tree`s that can be used for debugging. * Invariant checking improved: * Remove invariant that `pProps` domain should equal to all children and that domain of `pGraph` equals to the domain of `pProps` * Enforce that all children are uniqe and that parents are correctly specified and matches the inverse relation from a parent to the child
8b7cb1b
to
eafb95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix test data generation and improve invariant checking:
Fix
Arbitrary
instance forProposals
:InfoAction
andTreasuryWithdrawal
Remove
proposalsAreConsistent
in favor oftoPForest
. Besideschecking the invariant it also constructs a forest of
Tree
s thatcan be used for debugging.
Invariant checking improved:
pProps
domain should equal to all childrenand that domain of
pGraph
equals to the domain ofpProps
specified and matches the inverse relation from a parent to the
child
toPForest
not only checks the invariant, but serves as a nice debugging tool, since it allows us to print the hierarchy in a readable fashion, eg.:Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)