Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed ProposalProcedure in GovActionState #4028

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Embed ProposalProcedure in GovActionState #4028

merged 1 commit into from
Feb 6, 2024

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Jan 30, 2024 •
edited
Loading

Resolves #4019

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@TimSheard TimSheard force-pushed the ts-ProposalInGovActionState branch 2 times, most recently from e24ae88 to 6234081 Compare January 30, 2024 23:46
@TimSheard TimSheard requested review from lehins and Soupstraw January 31, 2024 00:03
@TimSheard TimSheard force-pushed the ts-ProposalInGovActionState branch from 6234081 to 342cb74 Compare January 31, 2024 17:17
@TimSheard TimSheard changed the title WIP ProposalProcedure embedd in GovActionState Embed ProposalProcedure in GovActionState Jan 31, 2024
lehins
lehins reviewed Jan 31, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance.hs Show resolved Hide resolved
@TimSheard TimSheard force-pushed the ts-ProposalInGovActionState branch from 342cb74 to ed3fb85 Compare January 31, 2024 19:29
@TimSheard TimSheard force-pushed the ts-ProposalInGovActionState branch 2 times, most recently from 0e807f2 to b5dd623 Compare February 1, 2024 16:18
lehins
lehins approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Just needs a rebase on master

@TimSheard TimSheard force-pushed the ts-ProposalInGovActionState branch from b5dd623 to fbf5a18 Compare February 5, 2024 23:08
@TimSheard TimSheard force-pushed the ts-ProposalInGovActionState branch from fbf5a18 to c9809f6 Compare February 6, 2024 16:54
@lehins lehins enabled auto-merge February 6, 2024 17:03
@lehins lehins force-pushed the ts-ProposalInGovActionState branch from c9809f6 to d1b9edf Compare February 6, 2024 19:02
@lehins lehins merged commit 6781c27 into master Feb 6, 2024
10 of 20 checks passed
@neilmayhew neilmayhew deleted the ts-ProposalInGovActionState branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store the full Proposal in the GovActionState
2 participants
@TimSheard @lehins