-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Conway-specific queries only available in Conway #4033
Conversation
76f5161
to
c631d6f
Compare
c631d6f
to
f163fb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on when you merge this, but to me it doesn't seem like you need any (EDIT:) major version bumps, because the backwards incompatible changes (removing the functions from the typeclasses) are in shelley and can go in the unreleased 1.10 version, which the other packages already depend on. Conway 1.13 which now contains Constitution is also not released yet, so no bump needed there either.
If I understood correctly the slack conversation about versions and typeclass changes, unless any of the packages are exporting these removed functions, they don't need a bump. EDIT: they do need non-breaking bump, sorry for the confusion
@teodanciu They do need a bump, just not a breaking version bump |
Makes sense if I think about it. Thanks for clarifying |
6baa5dc
to
849f6d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just need to fixup versions and changelogs
eras/shelley-ma/test-suite/cardano-ledger-shelley-ma-test.cabal
Outdated
Show resolved
Hide resolved
8cb4d1e
to
7b05234
Compare
7b05234
to
8267b8c
Compare
8267b8c
to
84aa035
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you.
Description
Resolves #4010
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)