Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the prose being inconsistent with the figure #4042

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

WhatisRT
Copy link
Contributor

@WhatisRT WhatisRT commented Feb 2, 2024

Description

Found by @HeinrichApfelmus. @TimSheard can you check that the second field in RewardUpdate does go into the reserves in the code?

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@HeinrichApfelmus
Copy link
Contributor

Credit for prompting the cross-check between prose and figure goes to @KtorZ .

@KtorZ
Copy link
Contributor

KtorZ commented Feb 2, 2024

Was it me 😅? Maybe, I just remember complaining about stuff, which sounds a lot like me.

@lehins lehins requested a review from TimSheard February 9, 2024 16:33
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I carefully looked at the code, and explained what I found. So I believe the reserves are updated as they should be.

@lehins lehins force-pushed the andre/shelley-spec-fix branch from 9b26f72 to cca7b5c Compare February 28, 2024 22:03
@lehins lehins enabled auto-merge February 28, 2024 22:03
@lehins lehins force-pushed the andre/shelley-spec-fix branch 2 times, most recently from 76fe4a8 to a25e0aa Compare February 29, 2024 10:36
@lehins lehins force-pushed the andre/shelley-spec-fix branch from a25e0aa to b259644 Compare February 29, 2024 13:44
@lehins lehins merged commit 70feccd into master Feb 29, 2024
16 checks passed
@neilmayhew neilmayhew deleted the andre/shelley-spec-fix branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants