Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Plutus scripts in ImpTest #4049

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Feb 5, 2024

Description

This PR adds the necessary fixup phases to make it possible to submit transactions which need to run scripts. I also converted the fixup pipeline to a point-free representation in order to improve readability and make it easier to modify the pipeline.

resolves #4022

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/plutus-imptest branch 5 times, most recently from 0372602 to fb163f3 Compare February 6, 2024 15:25
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that the PR is still a draft, that's why I haven't read through it in detail, just skimmed through it real quick out of curiosity of where it is heading. Here is some of my feedback
🚀

@Soupstraw Soupstraw force-pushed the jj/plutus-imptest branch 15 times, most recently from dd0f239 to 01a9210 Compare February 7, 2024 12:46
@Soupstraw Soupstraw marked this pull request as ready for review February 7, 2024 12:47
@Soupstraw Soupstraw force-pushed the jj/plutus-imptest branch 3 times, most recently from fa0da43 to b2b609e Compare February 7, 2024 14:50
@Soupstraw Soupstraw enabled auto-merge (rebase) February 7, 2024 14:59
Copy link
Contributor

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look. LGTM but I will let others to approve as I am not that familiar with the codebase yet.

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!
I only had some minor comments.

@Soupstraw Soupstraw force-pushed the jj/plutus-imptest branch 8 times, most recently from f360e03 to ce70c14 Compare February 8, 2024 11:20
@Soupstraw Soupstraw merged commit 84bf9e7 into master Feb 8, 2024
11 of 20 checks passed
@Soupstraw Soupstraw deleted the jj/plutus-imptest branch February 8, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Plutus scripts in ImpTest
3 participants