Fixed the 'All Tx are valid on traces of length 150' intermittent bug #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
ts-fix-allvalidsignals
branch
2 times, most recently
from
8d6cfad to
d201101
Compare
lehins
approved these changes
Feb 6, 2024
TimSheard
force-pushed
the
ts-fix-allvalidsignals
branch
from
d201101 to
b338230
Compare
…l in one place Added 'reasonable' to ensure bad PParamUpdates are not used. Fixed the 'All Tx are valid on traces of length 150' bug Fixed the 'listSumRangeUpper.Int8.prop_sound' bug
TimSheard
force-pushed
the
ts-fix-allvalidsignals
branch
from
b338230 to
b01c116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the 'All Tx are valid on traces of length 150' bug.
This was occasionally triggered at the Epoch boundary when a ParameterChange Proposal was passed,
and the PParamUpdate made random (stupid) changes to fields that made the Tx in the trace no longer valid.
Prime candidates were PParam fields that affected the computation of the fee, legal Tx sizes, and min txout values, etc.
Added function 'reasonable' to ensure bad PParamUpdates are not used. Allows users to adjust PParamUpdates in Proposals
Added EraClass -- Everything you need to build Era polymorphic Tx, all in one place
I ran this test 1000's of times without a failure while I ate dinner. I hope we have fixed it for good.
Fixes #4057 addressing the '/listSumRangeUpper.Int8.prop_sound/' bug, because it made the tests fail.
Description
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)