Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support of random and quickcheck-transformers in impTest #4051

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Feb 5, 2024

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/imp-gen branch 2 times, most recently from c0e5472 to d378989 Compare February 6, 2024 12:14
Copy link
Contributor

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

* Export the whole of `quickcheck-transformer` from `Imp.Common`

* Add `MonadGen` instance for `ImpTestM`

* Implement interface that is planned to be added to `random`. Few extra
  type classes allow to drop usage of proxy with the MonadState
  interface as well as makes it possible to look into the state, instead
  of relaying on the generator being the state.

* Add Imp runners that return Gen

* Add `arbitrary` lifted to `MonadGen`

* Re-export `replicateM_` and `replicateM`
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@lehins lehins enabled auto-merge February 6, 2024 17:28
@lehins lehins merged commit af2e2a8 into master Feb 6, 2024
11 of 20 checks passed
@neilmayhew neilmayhew deleted the lehins/imp-gen branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants