Enable Plutus v1 reference scripts in Conway #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
7 times, most recently
from
fde565a to
ea00f8a
Compare
Soupstraw
requested review from
lehins and
aniketd
and removed request for
lehins
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
4 times, most recently
from
3dbf20b to
2fffd34
Compare
lehins
requested changes
Feb 12, 2024
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/ImpTest.hs
Outdated
Show resolved
Hide resolved
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/ImpTest.hs
Outdated
Show resolved
Hide resolved
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/ImpTest.hs
Outdated
Show resolved
Hide resolved
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/ImpTest.hs
Outdated
Show resolved
Hide resolved
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/ImpTest.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxosSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxosSpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
3 times, most recently
from
e26a23e to
605e5b1
Compare
lehins
reviewed
Feb 12, 2024
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/ImpTest.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
9 times, most recently
from
6277f31 to
eaac007
Compare
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
3 times, most recently
from
5411c36 to
2354dff
Compare
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
2 times, most recently
from
63b00a5 to
ec40566
Compare
lehins
reviewed
Feb 15, 2024
lehins
reviewed
Feb 15, 2024
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
from
ec40566 to
c3e2c76
Compare
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
from
c3e2c76 to
479f808
Compare
lehins
reviewed
Feb 15, 2024
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/ImpTest.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxosSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxosSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxosSpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
2 times, most recently
from
123bf4b to
30b53e8
Compare
lehins
reviewed
Feb 15, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxosSpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
9 times, most recently
from
01a2ef6 to
c0ff559
Compare
lehins
approved these changes
Feb 16, 2024
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Imp/Common.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Imp/Common.hs
Outdated
Show resolved
Hide resolved
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/ImpTest.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/plutusv1-refscripts
branch
from
c0ff559 to
59eb763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a check from conway that fails a transaction when it's trying to use reference scripts for Plutus V1.
I also added support for reference scripts in ImpTests.
resolves #3965
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)