Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong prose for new epoch environment #4064

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

WhatisRT
Copy link
Contributor

@WhatisRT WhatisRT commented Feb 9, 2024

Description

The environment for NEWEPOCH is empty, but the prose claimed otherwise. Found in #4043.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@WhatisRT WhatisRT requested a review from lehins February 9, 2024 13:37
@vsubhuman
Copy link

Does this also remove the mention that pools should be removed at the end of their retirement epoch?

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@lehins lehins force-pushed the andre/shelley-spec-fix-prose branch from dd35fbb to 79bf359 Compare February 13, 2024 16:45
@lehins lehins merged commit 122b85f into master Feb 13, 2024
13 of 15 checks passed
@vsubhuman
Copy link

Does this also remove the mention that pools should be removed at the end of their retirement epoch?

@WhatisRT ?

@WhatisRT
Copy link
Contributor Author

Ah, sorry, I missed that from the original discussion. Fixed in #4093.

@neilmayhew neilmayhew deleted the andre/shelley-spec-fix-prose branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants