Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AsIndex to AsIx #4070

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Rename AsIndex to AsIx #4070

merged 1 commit into from
Feb 13, 2024

Conversation

neilmayhew
Copy link
Contributor

Description

Resolves #4036

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just minor changes needed to the changelog

eras/alonzo/impl/CHANGELOG.md Outdated Show resolved Hide resolved
eras/alonzo/impl/CHANGELOG.md Outdated Show resolved Hide resolved
@lehins lehins enabled auto-merge February 13, 2024 11:03
@lehins lehins merged commit 8965413 into master Feb 13, 2024
14 checks passed
@neilmayhew neilmayhew deleted the neilmayhew/asix branch February 13, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename AsIndex to AsIx
2 participants