Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinue the mingw target in the nix build #4075

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

neilmayhew
Copy link
Contributor

Description

This should fix the CI failures we've been having for a while (due to the cddl executable not being available in the mingw build environment.

Fixes #4074

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@neilmayhew neilmayhew requested a review from lehins February 13, 2024 05:57
@neilmayhew
Copy link
Contributor Author

The Hydra CI succeeded, except for one test on Darwin x86. Maybe this is a flaky test? The failed build result is actually cached from an earlier PR.

@neilmayhew neilmayhew requested a review from aniketd February 13, 2024 06:00
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hydra CI looks a lot less red then before. Very nice!

@lehins lehins merged commit 9a529ef into master Feb 13, 2024
15 of 17 checks passed
@lehins
Copy link
Collaborator

lehins commented Feb 13, 2024

Maybe this is a flaky test?

That was a flaky test.

@neilmayhew neilmayhew deleted the neilmayhew/hydra-failures branch February 13, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting hydra CI to pass
2 participants