Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that a resigned CC cannot be reelected without removal #4080

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 14, 2024

Description

Resolves #4063

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested review from teodanciu and lehins February 14, 2024 11:07
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@aniketd aniketd force-pushed the aniketd/cc-member-resignation-reactivation branch 2 times, most recently from f72b80f to b787f1d Compare February 14, 2024 12:50
@aniketd aniketd enabled auto-merge (squash) February 14, 2024 12:51
@lehins lehins force-pushed the aniketd/cc-member-resignation-reactivation branch from b787f1d to 0b0fd06 Compare February 14, 2024 16:07
@aniketd aniketd merged commit 10ccc4a into master Feb 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test that resigned CC member can't be re-elected without removal
2 participants