Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PPUPPredFailure #4082

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Deprecate PPUPPredFailure #4082

merged 2 commits into from
Feb 15, 2024

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Feb 14, 2024

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

lehins added a commit that referenced this pull request Feb 14, 2024
Others will be removed in a separate PR: #4082
@lehins lehins changed the base branch from master to lehins/inject-failure February 14, 2024 15:38
@lehins lehins force-pushed the lehins/deprecate-PPUPPredFailure branch from e0ee561 to a6a718b Compare February 14, 2024 15:39
lehins added a commit that referenced this pull request Feb 14, 2024
Others will be removed in a separate PR: #4082
@lehins lehins force-pushed the lehins/inject-failure branch 2 times, most recently from c1691b7 to c8ce8d3 Compare February 14, 2024 19:23
lehins added a commit that referenced this pull request Feb 14, 2024
Others will be removed in a separate PR: #4082
lehins added a commit that referenced this pull request Feb 15, 2024
Others will be removed in a separate PR: #4082
@lehins lehins force-pushed the lehins/deprecate-PPUPPredFailure branch from a6a718b to 46c7db1 Compare February 15, 2024 10:54
@lehins lehins marked this pull request as ready for review February 15, 2024 10:58
@lehins lehins force-pushed the lehins/deprecate-PPUPPredFailure branch from 46c7db1 to 6b7416c Compare February 15, 2024 11:01
@lehins lehins changed the base branch from lehins/inject-failure to master February 15, 2024 17:39
@lehins lehins force-pushed the lehins/deprecate-PPUPPredFailure branch from 6b7416c to 5115292 Compare February 15, 2024 17:53
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins force-pushed the lehins/deprecate-PPUPPredFailure branch from d594431 to d0dcb66 Compare February 15, 2024 20:46
@lehins lehins merged commit 214cee0 into master Feb 15, 2024
13 checks passed
@neilmayhew neilmayhew deleted the lehins/deprecate-PPUPPredFailure branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants