Committee query improvements #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/cc-query-improvements
branch
2 times, most recently
from
8f292ff to
314430d
Compare
since it was needed only because we couldn't have era-specific queries in consensus
and move optionality to the `csQuorum` field within `CommitteeMembersState`, in order to return results from the query even when there is no elected committee. In this way, we can query the committee for the next epoch or registered hot keys, independenent of the current state of the elected committee.
teodanciu
force-pushed
the
td/cc-query-improvements
branch
from
314430d to
450108b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was initially meant to be a test to verify the behavior reported in this issue: #4001
However I realized that we could improve the query by returning results independent of whether there exists a current committee, since it's possible that we have relevant information even when there is no currently elected committee (for example: information about the next epoch committee, or about pre-authorized members).
It's possible that returning better results helps with clarifying the behavior reported in the bug, for which I added a test in the last commit.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)