Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a collection of test Plutus scripts for use in ImpTests #4096

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Feb 19, 2024

Description

This PR improves the Plutus scripts fixup pipeline so that whoever is writing the tests doesn't have to worry about adding the correct datums and redeemers when using one of the provided example scripts. The test writer can still add invalid datums and redeemers that would make the transaction fail and the fixup function will respect that.

resolves #4027

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/plutus-test-scripts branch 20 times, most recently from 5e0b9ff to 63cd0ce Compare February 26, 2024 15:56
@Soupstraw Soupstraw force-pushed the jj/plutus-test-scripts branch 3 times, most recently from fc9af2a to e4cf6bd Compare February 27, 2024 12:45
@Soupstraw Soupstraw marked this pull request as ready for review February 27, 2024 12:45
@Soupstraw Soupstraw force-pushed the jj/plutus-test-scripts branch 3 times, most recently from 57abe3c to 6af8736 Compare February 27, 2024 14:53
@Soupstraw Soupstraw force-pushed the jj/plutus-test-scripts branch 8 times, most recently from 7516d9a to af67f2e Compare February 28, 2024 10:28
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Only some suggestion, but nothing critical.

@Soupstraw Soupstraw force-pushed the jj/plutus-test-scripts branch 3 times, most recently from 813776d to 904cf60 Compare February 29, 2024 10:19
@Soupstraw Soupstraw force-pushed the jj/plutus-test-scripts branch 5 times, most recently from 509828e to a2eb959 Compare February 29, 2024 11:13
@Soupstraw Soupstraw enabled auto-merge (rebase) February 29, 2024 11:15
@Soupstraw Soupstraw force-pushed the jj/plutus-test-scripts branch 5 times, most recently from 9612377 to 2746a54 Compare February 29, 2024 14:27
@lehins lehins force-pushed the jj/plutus-test-scripts branch from 2746a54 to 2fe2e9f Compare February 29, 2024 16:46
@Soupstraw Soupstraw force-pushed the jj/plutus-test-scripts branch from 56fc69f to 0b54fa9 Compare February 29, 2024 16:51
@Soupstraw Soupstraw merged commit 06266f5 into master Feb 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a collection of test scripts available for every Plutus Version
2 participants