Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that unwithdrawn rewards contribute to voting power #4097

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 20, 2024

Description

Resolves #4062

  • Investigate rewards for DRep
  • Investigate UTxOs for SPO
  • Investigate rewards for SPO
  • Open appropriate issues to address the pending tests from the outcomes.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested a review from Soupstraw February 20, 2024 07:54
@aniketd aniketd force-pushed the aniketd/unwithdrawn-rewards-contribute-to-voting branch from 793e367 to 54338b3 Compare February 20, 2024 08:07
@aniketd aniketd requested review from lehins and TimSheard February 20, 2024 10:49
@aniketd aniketd force-pushed the aniketd/unwithdrawn-rewards-contribute-to-voting branch 6 times, most recently from 5deec50 to 8c79dbd Compare February 21, 2024 12:28
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

This this for both DReps and SPOs.
@aniketd aniketd force-pushed the aniketd/unwithdrawn-rewards-contribute-to-voting branch from bb0e7ec to a3fbe05 Compare February 21, 2024 19:41
@aniketd aniketd requested a review from lehins February 21, 2024 19:42
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins enabled auto-merge February 21, 2024 19:52
@lehins lehins merged commit 51da777 into master Feb 21, 2024
13 checks passed
@neilmayhew neilmayhew deleted the aniketd/unwithdrawn-rewards-contribute-to-voting branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test: rewards that are not withdrawn contribute to voting power
2 participants