Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPU wellformedness tests #4100

Merged
merged 3 commits into from
Feb 21, 2024
Merged

PPU wellformedness tests #4100

merged 3 commits into from
Feb 21, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 20, 2024

Description

Resolves #4090

  1. The minUTxOValue check is deprecated in alonzo but still present in a version of the spec here
  2. The GovActionLifetime <= DRepActivity check was missing and has been added. This change has been reverted.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested review from lehins and Soupstraw February 20, 2024 10:42
@aniketd aniketd force-pushed the aniketd/pparams-wellformed branch from a3a78af to 8219952 Compare February 20, 2024 13:18
@aniketd aniketd force-pushed the aniketd/pparams-wellformed branch from bde2cc0 to d689fb8 Compare February 21, 2024 11:27
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
Thank you!

@lehins lehins merged commit 36e2043 into master Feb 21, 2024
13 checks passed
@neilmayhew neilmayhew deleted the aniketd/pparams-wellformed branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImpTest that PPrams well formedness is checked according to the spec
2 participants