Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance policy tests #4104

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Governance policy tests #4104

merged 6 commits into from
Mar 4, 2024

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Feb 20, 2024

Description

Closes #4089

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu marked this pull request as draft February 20, 2024 18:36
@teodanciu teodanciu changed the title Td/gov policy tests Governance policy tests Feb 20, 2024
@teodanciu teodanciu force-pushed the td/gov-policy-tests branch 3 times, most recently from c61ae5f to 970a2e3 Compare February 23, 2024 17:49
@teodanciu teodanciu marked this pull request as ready for review February 23, 2024 17:49
@teodanciu teodanciu force-pushed the td/gov-policy-tests branch 2 times, most recently from d921d99 to 2493325 Compare February 23, 2024 18:37
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented tests to check more or less what we need, but the way they are written can be improved. Let me know if my comments aren't clear I'll be happy to meet and talk about it.

Also use `arbitrary` instead of hardcoded values, and remove/rearrange
some tests
@teodanciu teodanciu force-pushed the td/gov-policy-tests branch 5 times, most recently from b26a765 to 97d4e83 Compare March 1, 2024 15:38
@teodanciu teodanciu force-pushed the td/gov-policy-tests branch from 97d4e83 to 842b1e3 Compare March 1, 2024 18:12
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!

@lehins lehins enabled auto-merge March 3, 2024 21:39
@lehins lehins merged commit 16ff034 into master Mar 4, 2024
16 checks passed
@neilmayhew neilmayhew deleted the td/gov-policy-tests branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImpTest Governance Policy is executed
2 participants