Imp Bootstrap address support #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/transition-shelley-test-1
branch
3 times, most recently
from
36504e8
to
58fb889
Compare
lehins
force-pushed
the
lehins/transition-shelley-test-1
branch
3 times, most recently
from
a62c3f4
to
42d7ed5
Compare
teodanciu
reviewed
Feb 27, 2024
lehins
force-pushed
the
lehins/transition-shelley-test-1
branch
2 times, most recently
from
7c00166
to
3d45adf
Compare
teodanciu
approved these changes
Feb 27, 2024
Soupstraw
reviewed
Feb 27, 2024
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/KeyPair.hs
Outdated
Show resolved
Hide resolved
lehins
force-pushed
the
lehins/transition-shelley-test-1
branch
from
3d45adf
to
10447e3
Compare
lehins
force-pushed
the
lehins/transition-shelley-test-1
branch
3 times, most recently
from
12e2a38
to
ae09f90
Compare
`addRootTxIn` already takes care of that step
* Add `Uniform` instances for `ByronKeyPair` and `KeyPair` * Add `mkKeyPairWithSeed`. Reduce duplication * Add `mkBootKeyPairWithSeed` * Move `genByronVKeyAddr` and `genByronAddrFromVKey` from `cardano-ledger-shelley-test`
* Change how we initialize ImpState. Utilize randomness. * Starte generating collateral inputs on demand instead of precreating them during initialization * Remove usage of a hacky hash index in favor of randomly generated hashes and key pairs * Add random bootstrap address generation * Stop overwriting existing witnesses. This is useful for supplying knowingly invalid witnesses. * Avoid requiring key witnesses for native scripts that were already provided
* Tests equivalent to `testBootstrapSpending` and `testBootstrapNotSpending` where implemented in `cardano-ledger-shelley:teslib:Test.Cardano.Ledger.Shelley.Imp.UtxowSpec` * `bootstrapHashTest` has been migrated to `cardano-ledger-core:test` * Moved `genBootstrapAddress` to `cardano-ledger-core:testlib:Test.Cardano.Ledger.Core.KeyPairs`
lehins
force-pushed
the
lehins/transition-shelley-test-1
branch
from
ae09f90
to
1ae999e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has a few important changes to ImpSpec:
arbitrarygoing into an infinite loopcardano-ledger-shelley-testChecklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)