Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewConstraints phase1. Add BoolFn And and Or and tests #4119

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Feb 26, 2024

Add And and Or to BoolFn
complete the necessary instances
add the test mapSizeConstrained as a baseline for future work.
add a test for (&&.) and (||.)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@TimSheard TimSheard force-pushed the ts-newconstaintsPhase1-BoolAdditions branch from 792c2a3 to b4e2ca1 Compare February 27, 2024 00:12
@TimSheard TimSheard changed the title Add BoolFn And and Or and tests NewConstraints phase1. Add BoolFn And and Or and tests Feb 27, 2024
@TimSheard TimSheard force-pushed the ts-newconstaintsPhase1-BoolAdditions branch from b4e2ca1 to 76de48d Compare February 27, 2024 23:14
@TimSheard TimSheard merged commit 13facd5 into master Feb 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants