Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MemoBytes in ShelleyTxAuxData #4122

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Feb 27, 2024

Description

Resolves #3958

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky marked this pull request as ready for review February 28, 2024 04:05
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect! Thank you!

@lehins lehins force-pushed the lucsanszky/shelleytx-memobytes branch 2 times, most recently from 14d5c4b to f733d42 Compare February 28, 2024 12:12
@lehins lehins force-pushed the lucsanszky/shelleytx-memobytes branch from f733d42 to 45b16e7 Compare February 28, 2024 14:01
@lehins lehins merged commit 61e9927 into master Feb 28, 2024
22 checks passed
@neilmayhew neilmayhew deleted the lucsanszky/shelleytx-memobytes branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch ShelleyTxAuxData to use MemoBytes
2 participants