Add extra time from 1 sec to 2 sec for prop_soundness test. #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
reviewed
Feb 28, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Tests.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-moretime-prop_soundness
branch
from
8de41d8
to
30c934c
Compare
lehins
requested changes
Mar 5, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Tests.hs
Outdated
Show resolved
Hide resolved
Did this by moving the 'within' clause to prop_soundess call site, and removing it from constraintProperty.
TimSheard
force-pushed
the
ts-moretime-prop_soundness
branch
from
30c934c
to
d9ac6d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issue #4137
Adds more time to prop_soundness. This is a big test. It looks like it times out infrequently, over running its 1 second
time bound. I upped the time bound from 1 to 2 seconds.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)