Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imptests for delaying actions enactment #4144

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 29, 2024

Description

Resolves #4127

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested review from lehins and Soupstraw February 29, 2024 15:58
@aniketd aniketd force-pushed the aniketd/delaying-works-as-expected branch from 536ea9e to 301146b Compare February 29, 2024 16:07
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@aniketd aniketd force-pushed the aniketd/delaying-works-as-expected branch from 301146b to 9cf1850 Compare February 29, 2024 17:02
@aniketd aniketd enabled auto-merge (squash) February 29, 2024 17:03
@aniketd aniketd force-pushed the aniketd/delaying-works-as-expected branch from 9cf1850 to fa7cabb Compare February 29, 2024 19:39
@aniketd aniketd merged commit 95ee9c4 into master Feb 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imp test for checking delaying works as expected
2 participants