Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPO stake distr calc for HardForkInitiation #4154

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Mar 4, 2024

With tests

Description

Resolves #4146

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested review from lehins and Soupstraw March 4, 2024 15:45
@aniketd aniketd force-pushed the aniketd/spo-votes-calc branch 2 times, most recently from c1faa8b to 256f78c Compare March 5, 2024 18:28
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice catch on iterating over stake distribution instead of votes!

@aniketd aniketd force-pushed the aniketd/spo-votes-calc branch 3 times, most recently from be9d5b5 to dabd930 Compare March 6, 2024 12:34
@aniketd aniketd enabled auto-merge (squash) March 6, 2024 12:35
@aniketd aniketd force-pushed the aniketd/spo-votes-calc branch from dabd930 to 2be5a16 Compare March 6, 2024 12:50
@lehins lehins force-pushed the aniketd/spo-votes-calc branch 2 times, most recently from 3896093 to 0b0669f Compare March 6, 2024 17:41
@lehins lehins force-pushed the aniketd/spo-votes-calc branch from 0b0669f to 3bf6121 Compare March 6, 2024 19:52
@aniketd aniketd merged commit c5c174d into master Mar 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure SPO voting is counted correctly
2 participants