Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly build failures #4155

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Fix nightly build failures #4155

merged 3 commits into from
Mar 8, 2024

Conversation

neilmayhew
Copy link
Contributor

Description

  • Fix nightly build failures
  • Allow simulating a nightly build when manually triggering a build

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@neilmayhew neilmayhew force-pushed the neilmayhew/nightly-failures branch 2 times, most recently from ce61d18 to 03fece1 Compare March 5, 2024 04:21
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
In case it's easier to test: I have used a fork repo to play with the build and actions, to keep the things needed just for testing separate from what I wanted to merge (just in case the idea is useful to you too)

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehins
Copy link
Contributor

lehins commented Mar 5, 2024

There are still flaky tests that are failing to discards. But, it is one step closer to nightly builds going green

@neilmayhew
Copy link
Contributor Author

Looks good to me. In case it's easier to test: I have used a fork repo to play with the build and actions, to keep the things needed just for testing separate from what I wanted to merge (just in case the idea is useful to you too)

Thanks! That's a great idea. It looks like I don't need it for now, but I'll definitely keep that in mind for the future.

@neilmayhew neilmayhew disabled auto-merge March 5, 2024 18:38
@neilmayhew
Copy link
Contributor Author

@lehins Would you do an admin merge, please? I can't get this to pass all of the matrix builds at the same time, since it's running the nightly tests.

Also, it takes so long to run that master has usually been updated by the time I can run it again. However, it should rebase cleanly on top of the changes merged to master today.

@lehins
Copy link
Contributor

lehins commented Mar 5, 2024

@neilmayhew Sounds good. I'll take care of merging this PR.

@lehins lehins force-pushed the neilmayhew/nightly-failures branch 2 times, most recently from 88f9088 to e79bcad Compare March 7, 2024 14:58
This avoids warnings about deprecated node versions
* Remove nix build job
* Increase memory allocation for shelley-ma-test
@lehins lehins force-pushed the neilmayhew/nightly-failures branch from e79bcad to 2bc26cb Compare March 7, 2024 19:58
@lehins lehins merged commit 0d96dab into master Mar 8, 2024
14 of 15 checks passed
@neilmayhew neilmayhew deleted the neilmayhew/nightly-failures branch March 8, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants