-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly build failures #4155
Conversation
ce61d18
to
03fece1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
In case it's easier to test: I have used a fork repo to play with the build and actions, to keep the things needed just for testing separate from what I wanted to merge (just in case the idea is useful to you too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are still flaky tests that are failing to discards. But, it is one step closer to nightly builds going green |
b94972d
to
73a9496
Compare
Thanks! That's a great idea. It looks like I don't need it for now, but I'll definitely keep that in mind for the future. |
@lehins Would you do an admin merge, please? I can't get this to pass all of the matrix builds at the same time, since it's running the nightly tests. Also, it takes so long to run that |
@neilmayhew Sounds good. I'll take care of merging this PR. |
88f9088
to
e79bcad
Compare
This avoids warnings about deprecated node versions
* Remove nix build job * Increase memory allocation for shelley-ma-test
e79bcad
to
2bc26cb
Compare
Description
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)