Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Conway governance #4157

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Split Conway governance #4157

merged 3 commits into from
Mar 5, 2024

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Mar 4, 2024

Description

There are no semantic changes here. This PR only splits Governance.hs module into three, while preserving git history (despite what the diff might be showing)

The module grew pretty big, but I wanted to separate the DRep pulser out into its own module. In order to get it done we need this split.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

In order to preserve git history we first make three identical copies of
the same module.
@lehins lehins force-pushed the lehins/split-conway-governance branch from bd3092c to 5573ef0 Compare March 4, 2024 21:09
@lehins lehins requested review from teodanciu and aniketd March 4, 2024 21:12
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins force-pushed the lehins/split-conway-governance branch from 5573ef0 to b7f8e7e Compare March 4, 2024 23:20
@lehins lehins enabled auto-merge March 4, 2024 23:20
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🙌

@lehins lehins force-pushed the lehins/split-conway-governance branch from b7f8e7e to 97e5870 Compare March 5, 2024 12:04
@lehins lehins force-pushed the lehins/split-conway-governance branch from 97e5870 to 0f76f1f Compare March 5, 2024 15:13
@lehins lehins merged commit 829ab73 into master Mar 5, 2024
15 of 17 checks passed
@neilmayhew neilmayhew deleted the lehins/split-conway-governance branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants