Shelley rules cleanup #4159
Merged
Shelley rules cleanup #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/shelley-rules-cleanup
branch
2 times, most recently
from
4f048f2
to
e6fd30f
Compare
lehins
force-pushed
the
lehins/shelley-rules-cleanup
branch
2 times, most recently
from
addb166
to
e108e7e
Compare
teodanciu
reviewed
Mar 7, 2024
teodanciu
reviewed
Mar 7, 2024
teodanciu
reviewed
Mar 7, 2024
teodanciu
approved these changes
Mar 7, 2024
lehins
force-pushed
the
lehins/shelley-rules-cleanup
branch
3 times, most recently
from
817f874
to
7c3d79e
Compare
* Stop running `hasLegalProtVerUpdate` check on the current PParams when submitted update contains invalid values * Change `NewppEnv` to accept `CertState`
* `proposals` to `sgsCurProposals` * `futureProposals` to `sgsFutureProposals` * `sgovPp` to `sgsCurPParams` * `sgovPrevPp` to `sgsPrevPParams`
teodanciu
force-pushed
the
lehins/shelley-rules-cleanup
branch
from
7c3d79e
to
a219917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Collection of improvements to Shelley rules. This work is done as part of preparation to implementing #4006
Probably easier to review commit by commit
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)