Make shelley TxWits consistent with other eras
#4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
force-pushed
the
lucsanszky/txwits-consistency
branch
from
a2c1f39 to
2c13d0b
Compare
|
I also moved I'll also update the |
lehins
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Looking good.
I also moved mapTraverseableDecoderA from Alonzo.TxWits to Shelley.TxWits.
That's totally fine
Although, it might be better to move it to Decoding in cardano-ledger-binary. Any suggestions?
In not so distant future we will be getting rid of Annotator, so we don't really need to worry about the ideal placement for this function.
lehins
reviewed
Mar 5, 2024
Lucsanszky
force-pushed
the
lucsanszky/txwits-consistency
branch
from
773b14a to
9d21290
Compare
Lucsanszky
force-pushed
the
lucsanszky/txwits-consistency
branch
2 times, most recently
from
671ee71 to
f096291
Compare
Which means: * Remove `HKD` * Use `MemoBytes` * Replace `(Era era, NoThunks (Script era))` with `EraScript era`
lehins
force-pushed
the
lucsanszky/txwits-consistency
branch
from
f096291 to
43673d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3959
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)