Add ConwayDRepIncorrectRefund and tests for GovCert
#4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/incorrect-refund
branch
2 times, most recently
from
a3877da to
aac516b
Compare
Soupstraw
force-pushed
the
jj/incorrect-refund
branch
2 times, most recently
from
0d2e8ef to
a69b758
Compare
Soupstraw
force-pushed
the
jj/incorrect-refund
branch
from
a69b758 to
3d03ee0
Compare
Soupstraw
changed the title
ConwayDRepIncorrectRefundConwayDRepIncorrectRefund and tests for GovCert
Soupstraw
force-pushed
the
jj/incorrect-refund
branch
5 times, most recently
from
cfdf2d0 to
56cbd9f
Compare
Soupstraw
force-pushed
the
jj/incorrect-refund
branch
3 times, most recently
from
5b8b73c to
6d55f8f
Compare
lehins
force-pushed
the
jj/incorrect-refund
branch
from
6d55f8f to
de149fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
ConwayDRepIncorrectRefundpredicate failure toGOVCERT. This failure happens when trying to unregister a DRep with invalidCoinin the cert. I also added tests for otherGOVCERTpredicate failures.resolves #4135
resolves #4136
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)