Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise GovSpec, add GovCertSpec #4163

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Reorganise GovSpec, add GovCertSpec #4163

merged 1 commit into from
Mar 6, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Mar 5, 2024

Description

Resolves #4148

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/reorg-govspec branch from 9004f8e to 49793ef Compare March 5, 2024 16:39
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

eras/conway/impl/cardano-ledger-conway.cabal Show resolved Hide resolved
@lehins lehins force-pushed the aniketd/reorg-govspec branch from 49793ef to 3ac49a4 Compare March 5, 2024 18:21
@aniketd aniketd force-pushed the aniketd/reorg-govspec branch from 3ac49a4 to c9fc206 Compare March 5, 2024 18:27
@lehins lehins force-pushed the aniketd/reorg-govspec branch from c9fc206 to c23abd5 Compare March 5, 2024 20:49
@lehins lehins enabled auto-merge March 5, 2024 20:49
@lehins lehins force-pushed the aniketd/reorg-govspec branch from c23abd5 to d614dbf Compare March 5, 2024 23:21
@lehins lehins merged commit 5292bc6 into master Mar 6, 2024
13 of 17 checks passed
@neilmayhew neilmayhew deleted the aniketd/reorg-govspec branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize GovSpec
2 participants