-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GovInfoEvent
and add event testing capabilities to ImpTest
#4169
Conversation
7fba68f
to
3883f4d
Compare
5f0c672
to
6ecc76f
Compare
GovInfoEvent
GovInfoEvent
and add event testing capabilities to ImpTest
6bcdf07
to
9c0dae8
Compare
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Imp/Common.hs
Outdated
Show resolved
Hide resolved
Will finish reviewing tomorrow, there's a lot here! (some of it above my head) |
72ff7e5
to
04b42c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't understand what we wouldn't be able to do without the new EraRuleEvent
( I don't even see any type annotations being removed, if anything, we seem to have added more , like going from:
mapM_ (tellEvent . SuccessfulPlutusScriptsEvent) (nonEmpty ps)
to mapM_ (tellEvent . injectEvent @"UTXOS" . SuccessfulPlutusScriptsEvent @era) (nonEmpty ps)
, for example ),
but I can tell it's the technique used for EraRuleFailure
, so I'll approve and hope to understand better one day.
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/EpochSpec.hs
Outdated
Show resolved
Hide resolved
04b42c6
to
ac6aadb
Compare
ac6aadb
to
82c7d79
Compare
The main point for adding |
Description
This PR adds an event to
EPOCH
which contains sets with expired and enacted governance actions and a set with all the governance action IDs that are unclaimed.I also added a way to write tests about events and cleaned up Conway events. The
ConwayUtxosEvent
is necessary because we have to get rid ofPPUP
events in Conway as we no longer have aPPUP
rule.resolves #4165
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)