Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imptests for some more GOV predicate failures #4172

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Mar 6, 2024

Description

Resolves #4134

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested a review from lehins March 6, 2024 14:32
@aniketd aniketd force-pushed the aniketd/gov-predicate-failures branch from 2083bb8 to 7547efc Compare March 6, 2024 14:32
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehins lehins enabled auto-merge March 6, 2024 14:41
- ExpirationEpochTooSmall
- ProposalDepositIncorrect
- ConflictingCommitteeUpdate
@aniketd aniketd force-pushed the aniketd/gov-predicate-failures branch from 7547efc to 21db182 Compare March 6, 2024 17:23
@lehins lehins merged commit 2d32799 into master Mar 6, 2024
15 of 17 checks passed
@neilmayhew neilmayhew deleted the aniketd/gov-predicate-failures branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imp test for predicate checks in the GOV rule
2 participants