Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update profiling instructions #4173

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

MaximilianAlgehed
Copy link
Collaborator

Description

I had to do some work to get profiling to work and after talking to MPJ things worked on my machine.

I've updated the instructions to reflect what I had to do but I would be very happy if @TimSheard or someone could try the new instructions on their machine as well.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@lehins lehins force-pushed the PR-update-profiling-instructions branch from c415798 to c138e7a Compare March 6, 2024 17:41
@lehins lehins enabled auto-merge March 6, 2024 17:41
@lehins lehins force-pushed the PR-update-profiling-instructions branch 2 times, most recently from 3dfcc8f to 30a0685 Compare March 6, 2024 22:52
@lehins lehins force-pushed the PR-update-profiling-instructions branch from 30a0685 to 441ad5b Compare March 7, 2024 01:07
@lehins lehins merged commit 64bda98 into master Mar 7, 2024
16 checks passed
@neilmayhew neilmayhew deleted the PR-update-profiling-instructions branch March 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants