Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unsafeMkProposals to be used for testing #4197

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

MaximilianAlgehed
Copy link
Collaborator

@MaximilianAlgehed MaximilianAlgehed commented Mar 13, 2024

Description

When profiling prop_GOV that I'm working on over on the branch PR-fix-prop_GOV I found that after fixing a bunch of performance bottle necks in constrained-generators (now running many X faster!) checkInvariantAfterAddition was taking 24% of the time. This seemed excessive as the whole point of the constraint-based generator is to generate correct stuff by default.

This PR adds unsafeMkProposals to make it possible to side-step checkInvariantAfterAddition when generating test data.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-add-unsafe-proposals branch from 3cb4080 to c3420e0 Compare March 14, 2024 15:49
@MaximilianAlgehed MaximilianAlgehed merged commit 6d86029 into master Mar 14, 2024
15 checks passed
@neilmayhew neilmayhew deleted the PR-add-unsafe-proposals branch March 28, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants