Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CC ratification when number of members is below ppCommitteeMinSize #4205

Merged
merged 1 commit into from Mar 21, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Mar 19, 2024

Description

This PR fixes the voting thresholds so that if the size of active CC members is below ccMinSize, then the CC cannot pass any proposals. The previous implementation did not check how many CC members have resigned, thus counting all of the CC members as active members.

resolves #4204

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/resigned-cc-bug branch 2 times, most recently from f857b37 to 602bece Compare March 19, 2024 14:20
@Soupstraw Soupstraw enabled auto-merge (rebase) March 19, 2024 15:34
@teodanciu
Copy link
Contributor

I have some questions about this, maybe we could discuss it in the meeting today?

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Would you mind changing the commit message to specify that it changes the voting committee threshold calculation to take into account member resignation?
It's will make our life easier when we have to produce release notes and cardano updates.

Copy link
Contributor

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly added a comment for now but I'm planning to have a better look at this later today.

@teodanciu teodanciu changed the title Disable CC voting when number of members is below ppCommitteeMinSize Disable CC ratification when number of members is below ppCommitteeMinSize Mar 21, 2024
@Soupstraw Soupstraw merged commit b1be2ff into master Mar 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resigned CC members can approve actions
5 participants