-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable CC ratification when number of members is below ppCommitteeMinSize
#4205
Conversation
f857b37
to
602bece
Compare
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Internal.hs
Outdated
Show resolved
Hide resolved
602bece
to
3993d60
Compare
I have some questions about this, maybe we could discuss it in the meeting today? |
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs
Outdated
Show resolved
Hide resolved
3993d60
to
30ceaf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Would you mind changing the commit message to specify that it changes the voting committee threshold calculation to take into account member resignation?
It's will make our life easier when we have to produce release notes and cardano updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly added a comment for now but I'm planning to have a better look at this later today.
30ceaf9
to
c09dc51
Compare
c09dc51
to
73874bd
Compare
ppCommitteeMinSize
ppCommitteeMinSize
Description
This PR fixes the voting thresholds so that if the size of active CC members is below
ccMinSize
, then the CC cannot pass any proposals. The previous implementation did not check how many CC members have resigned, thus counting all of the CC members as active members.resolves #4204
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)