Remove missingScriptsSymmetricDifference #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilmayhew
force-pushed
the
neilmayhew/missingScriptsSymmetricDifference
branch
2 times, most recently
from
f13118a
to
eca97e2
Compare
teodanciu
reviewed
Mar 20, 2024
teodanciu
reviewed
Mar 20, 2024
neilmayhew
force-pushed
the
neilmayhew/missingScriptsSymmetricDifference
branch
from
eca97e2
to
3877769
Compare
* Extraneous scripts now have a specific predicate failure * Also remove the `PParams` param from `validateMissingScripts` because the predicate failures are no longer version-specific Closes #3796
neilmayhew
force-pushed
the
neilmayhew/missingScriptsSymmetricDifference
branch
from
3877769
to
869117e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3796
Description
Extraneous scripts have had a specific predicate failure since Babbage and we no longer wish to support the backwards compatibility that this function enables.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)