Fix estimateMinFeeTx w/ bootstrap test
#4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
force-pushed
the
lucsanszky/fix-estimateminfeetx-underestimation
branch
3 times, most recently
from
72b2981
to
8eb1a92
Compare
lehins
force-pushed
the
lucsanszky/fix-estimateminfeetx-underestimation
branch
from
8eb1a92
to
ffa1edf
Compare
lehins
approved these changes
Apr 1, 2024
In the test, the overestimations were not scaled by the linear factor `a` of the fee (formula for min fee calculation: `a * txSize tx + b`). Only the overestimated transaction size was calculated and it was added to the fee without scaling. This caused the tests to fail when the linear factor was zero.
lehins
force-pushed
the
lucsanszky/fix-estimateminfeetx-underestimation
branch
from
ffa1edf
to
26c0d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property that we were asserting was wrong as the overestimations were not scaled by the linear factor of the fee, so we were basically adding the overestimated size, rather than the overestimated fee, to the fee and this was problematic in case the linear factor (
ppMinFeeA) was zero.Resolves #4124
Description
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)