-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrinking for constrained-generators
#4229
Conversation
It might be interesting for @Soupstraw to also have a look at this. Not required but spreading knowledge around isn't a bad thing. |
37527ad
to
51b3d46
Compare
94e5afc
to
859f5d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a new method to HasSpec, supplies the method for all the instances, and then adds some tests that the shrinking does not affect the results.
Just a few questions to answer. May be add some more comments.
859f5d2
to
320d1e4
Compare
320d1e4
to
d4d0cd4
Compare
Description
This implements shrinking for
constrained-generators
by embedding it in theHasSpec
class. There are still some TODOs that need to be covered but this should be relatively ready to look at.Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)